From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20926C47095 for ; Wed, 9 Jun 2021 07:39:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02EC86135D for ; Wed, 9 Jun 2021 07:39:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233922AbhFIHky (ORCPT ); Wed, 9 Jun 2021 03:40:54 -0400 Received: from mga02.intel.com ([134.134.136.20]:35878 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233673AbhFIHkx (ORCPT ); Wed, 9 Jun 2021 03:40:53 -0400 IronPort-SDR: U/aD8rpYH2ed20DY3VHHuoDngzMq1E4lDIH1da7b6mDAkOx0U2u9um3+tASiHY5vSulWEDvs7w 2A0WTk1ZGKNw== X-IronPort-AV: E=McAfee;i="6200,9189,10009"; a="192132376" X-IronPort-AV: E=Sophos;i="5.83,260,1616482800"; d="scan'208";a="192132376" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2021 00:38:58 -0700 IronPort-SDR: aymcSzkjsK4Lz0m+QUTmT6eeeCYEHc3zyaPEi7uTXFauEozHlNq4DdtHuYu8BdtzN1usKgamJn CU2VCD9sUJEQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,260,1616482800"; d="scan'208";a="552588612" Received: from allen-box.sh.intel.com (HELO [10.239.159.105]) ([10.239.159.105]) by fmsmga001.fm.intel.com with ESMTP; 09 Jun 2021 00:38:55 -0700 Cc: baolu.lu@linux.intel.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu: remove redundant assignment to variable agaw To: Colin King , David Woodhouse , Joerg Roedel , Will Deacon , iommu@lists.linux-foundation.org References: <20210416171826.64091-1-colin.king@canonical.com> From: Lu Baolu Message-ID: Date: Wed, 9 Jun 2021 15:37:38 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210416171826.64091-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On 4/17/21 1:18 AM, Colin King wrote: > From: Colin Ian King > > The variable agaw is initialized with a value that is never > read and it is being updated later with a new value as a > counter in a for-loop. The initialization is redundant and > can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Queued for v5.14. Thanks! Best regards, baolu