From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Julian Calaby <julian.calaby@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Cc: Arend Van Spriel <arend.vanspriel@broadcom.com>,
Eyal Reizer <eyalr@ti.com>, Iain Hunter <drhunter95@gmail.com>,
James Minor <james.minor@ni.com>,
Johannes Berg <johannes.berg@intel.com>,
Kalle Valo <kvalo@codeaurora.org>,
Maxim Altshul <maxim.altshul@ti.com>,
Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 4/5] wlcore: Use common error handling code in wlcore_set_beacon_template()
Date: Mon, 30 Oct 2017 13:44:31 +0000 [thread overview]
Message-ID: <bc692c11-63f8-a914-8767-1fc4248faae8@users.sourceforge.net> (raw)
In-Reply-To: <CAGRGNgUEFpva3ct-idAzip97eVgoDDTeEArAPcjvf90VSORA2g@mail.gmail.com>
>> @@ -4081,9 +4078,8 @@ static int wlcore_set_beacon_template(struct wl1271 *wl,
>> beacon->data,
>> beacon->len, 0,
>> min_rate);
>> -end_bcn:
>> +free_skb:
>
> Why rename the label?
I find it clearer according to the Linux coding style.
Regards,
Markus
next prev parent reply other threads:[~2017-10-30 13:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 20:10 [PATCH 0/5] wlcore: Fine-tuning for three function implementations SF Markus Elfring
2017-10-29 20:11 ` [PATCH 1/5] wlcore: Use common error handling code in wlcore_nvs_cb() SF Markus Elfring
2017-10-30 13:28 ` Julian Calaby
2017-10-30 13:40 ` SF Markus Elfring
2017-10-29 20:12 ` [PATCH 2/5] wlcore: Delete an unnecessary check statement in wlcore_set_beacon_template() SF Markus Elfring
2017-10-30 13:26 ` Julian Calaby
2017-10-29 20:13 ` [PATCH 3/5] wlcore: Return directly after a failed ieee80211_beacon_get() in wlcore_set_beacon_templ SF Markus Elfring
2017-10-30 13:32 ` [PATCH 3/5] wlcore: Return directly after a failed ieee80211_beacon_get() in wlcore_set_beacon_t Julian Calaby
2017-10-29 20:14 ` [PATCH 4/5] wlcore: Use common error handling code in wlcore_set_beacon_template() SF Markus Elfring
2017-10-30 13:33 ` Julian Calaby
2017-10-30 13:44 ` SF Markus Elfring [this message]
2017-10-29 20:16 ` [PATCH 5/5] wlcore: Use common error handling code in wl1271_op_suspend() SF Markus Elfring
2017-10-30 13:40 ` Julian Calaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc692c11-63f8-a914-8767-1fc4248faae8@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=arend.vanspriel@broadcom.com \
--cc=drhunter95@gmail.com \
--cc=eyalr@ti.com \
--cc=james.minor@ni.com \
--cc=johannes.berg@intel.com \
--cc=julian.calaby@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=maxim.altshul@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pieter-paul.giesberts@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox