From: Markus Elfring <Markus.Elfring@web.de>
To: Steve French <smfrench@gmail.com>,
linux-cifs@vger.kernel.org,
samba-technical <samba-technical@lists.samba.org>,
Bharath SM <bharathsm@microsoft.com>,
Paulo Alcantara <pc@manguebit.org>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>
Cc: Steve French <sfrench@samba.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: smb: client: Simplify a return statement in get_smb2_acl_by_path()
Date: Thu, 9 Oct 2025 07:17:40 +0200 [thread overview]
Message-ID: <bc8f02de-0cd5-475d-bb19-e44e202f7a58@web.de> (raw)
In-Reply-To: <CAH2r5mtpoLscs9sodXcRMO3-dqMDBSTR+ncExdqy4dQR=4uE8A@mail.gmail.com>
> This is an example of one that is probably slightly worth it,
Thanks for such a positive indication.
> it shrinks one line of code, and also doesn't have risk,
Similar source code refinements might become also interesting and helpful.
> but at least three of the others today don't shrink and sometimes grow lines of code (and don't fix anything )
Further update candidates can be found and eventually transformed also with the help
of the semantic patch language (Coccinelle software).
> so are unlikely to be worth it since they slightly increase risk of adding difficulty to stable backports of future fixes
I hope that such change resistance can be reconsidered.
Regards,
Markus
next prev parent reply other threads:[~2025-10-09 5:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 20:02 [PATCH] smb: client: Simplify a return statement in get_smb2_acl_by_path() Markus Elfring
2025-10-09 0:12 ` Steve French
[not found] ` <CAH2r5mtpoLscs9sodXcRMO3-dqMDBSTR+ncExdqy4dQR=4uE8A@mail.gmail.com>
2025-10-09 5:17 ` Markus Elfring [this message]
2025-10-09 15:29 ` Steve French
2025-10-09 15:44 ` Markus Elfring
2025-10-10 7:22 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc8f02de-0cd5-475d-bb19-e44e202f7a58@web.de \
--to=markus.elfring@web.de \
--cc=bharathsm@microsoft.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox