From: Jens Axboe <axboe@kernel.dk>
To: Johannes Thumshirn <jthumshirn@suse.de>,
SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-block@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/5] blk-throttle: Adjust two function calls together with a variable assignment
Date: Mon, 23 Jan 2017 15:14:38 +0000 [thread overview]
Message-ID: <bdd7466c-2f35-3279-1287-b08ba9eb373b@kernel.dk> (raw)
In-Reply-To: <20170123091821.GC3517@linux-x5ow.site>
On 01/23/2017 02:20 AM, Johannes Thumshirn wrote:
> On Sun, Jan 22, 2017 at 09:33:08AM +0100, SF Markus Elfring wrote:
>> From: Markus Elfring <elfring@users.sourceforge.net>
>> Date: Sat, 21 Jan 2017 22:15:33 +0100
>>
>> The script "checkpatch.pl" pointed information out like the following.
>>
>> ERROR: do not use assignment in if condition
>>
>> Thus fix the affected source code places.
>>
>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>> ---
>
> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
> if Jens wants doesn't mind.
I don't mind these, but I completely agree on the patches for moving the
'error' assignment. What ends up happening for those cases is that
someone adds a new section and forgets to set 'error', and then all hell
breaks lose.
So Markus, don't bother sending those patches again for the block layer
or drivers, I'm not going to take them.
--
Jens Axboe
next prev parent reply other threads:[~2017-01-23 15:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 8:30 [PATCH 0/5] block: Fine-tuning for five function implementations SF Markus Elfring
2017-01-22 8:31 ` [PATCH 1/5] blk-throttle: Move three assignments for the variable "ret" in tg_set_max() SF Markus Elfring
2017-01-23 9:15 ` Johannes Thumshirn
2017-01-23 10:00 ` SF Markus Elfring
2017-01-23 11:47 ` Johannes Thumshirn
2017-01-23 12:06 ` SF Markus Elfring
2017-01-23 15:17 ` Jens Axboe
2017-01-22 8:32 ` [PATCH 2/5] blk-throttle: Move an assignment for the variable "ret" in tg_set_conf() SF Markus Elfring
2017-01-23 9:16 ` Johannes Thumshirn
2017-01-22 8:33 ` [PATCH 3/5] blk-throttle: Adjust two function calls together with a variable assignment SF Markus Elfring
2017-01-23 9:20 ` Johannes Thumshirn
2017-01-23 15:14 ` Jens Axboe [this message]
2017-01-22 8:34 ` [PATCH 4/5] cfq-iosched: Move an assignment for the variable "ret" in __cfqg_set_weight_device() SF Markus Elfring
2017-01-22 8:35 ` [PATCH 5/5] cfq-iosched: Adjust one function call together with a variable assignment SF Markus Elfring
2017-01-23 9:21 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdd7466c-2f35-3279-1287-b08ba9eb373b@kernel.dk \
--to=axboe@kernel.dk \
--cc=elfring@users.sourceforge.net \
--cc=jthumshirn@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox