From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-s390@vger.kernel.org,
"Gerald Schäfer" <gerald.schaefer@de.ibm.com>,
"Heiko Carstens" <heiko.carstens@de.ibm.com>,
"Martin Schwidefsky" <schwidefsky@de.ibm.com>,
"Sebastian Ott" <sebott@linux.vnet.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 1/5] s390/pci: Return directly after a failed parameter validation in clp_normal_command()
Date: Sat, 21 Jan 2017 18:10:08 +0000 [thread overview]
Message-ID: <be482828-096c-889f-b916-1eb7ebe2368c@users.sourceforge.net> (raw)
In-Reply-To: <f2233afd-bc54-0697-0709-9577e96fc6a6@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 21 Jan 2017 17:49:00 +0100
Return directly after an inappropriate input parameter was detected.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/s390/pci/pci_clp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/s390/pci/pci_clp.c b/arch/s390/pci/pci_clp.c
index 1c3332ac1957..4f5a1bf3b14b 100644
--- a/arch/s390/pci/pci_clp.c
+++ b/arch/s390/pci/pci_clp.c
@@ -514,9 +514,8 @@ static int clp_normal_command(struct clp_req *req)
void __user *uptr;
int rc;
- rc = -EINVAL;
if (req->lps != 0 && req->lps != 2)
- goto out;
+ return -EINVAL;
rc = -ENOMEM;
lpcb = clp_alloc_block(GFP_KERNEL);
--
2.11.0
next prev parent reply other threads:[~2017-01-21 18:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-21 18:09 [PATCH 0/5] s390/pci: Fine-tuning for three function implementations SF Markus Elfring
2017-01-21 18:10 ` SF Markus Elfring [this message]
2017-01-21 18:11 ` [PATCH 2/5] s390/pci: Return directly after a failed clp_alloc_block() in clp_normal_command() SF Markus Elfring
2017-01-21 18:12 ` [PATCH 3/5] s390/pci: Move three assignments for the variable "rc" " SF Markus Elfring
2017-01-21 19:20 ` kbuild test robot
2017-01-21 18:13 ` [PATCH 4/5] s390/pci: Move an assignment for the variable "ret" in s390_pci_mmio_write() SF Markus Elfring
2017-01-23 8:58 ` Dan Carpenter
2017-01-21 18:14 ` [PATCH 5/5] s390/pci: Move two assignments for the variable "ret" in get_pfn() SF Markus Elfring
2017-01-23 8:55 ` [PATCH 0/5] s390/pci: Fine-tuning for three function implementations Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be482828-096c-889f-b916-1eb7ebe2368c@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=gerald.schaefer@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=sebott@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox