From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A4AC745C1 for ; Fri, 12 Jan 2024 16:18:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="TikfNHgX" Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-7bb5be6742fso78137139f.1 for ; Fri, 12 Jan 2024 08:18:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1705076326; x=1705681126; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kGo5Qib9p/CMqmc2qVWW+nsxV9z3k+DvCQknh7gy4Ww=; b=TikfNHgXxUFCbvfBPpEhlkO8PQD/CPuLpqY+r9fugo9iaLEktnSFF4jGJRk3Ws2DXc HsCOYiLGDFBIRTG96xHJZPzdyUz/oQPUZyXLhjuM7zBTeg+4FUbM2WFsZJ9FHR3bGJMa teqdxwU1ovOC2+DZb/QILZfqDqcAUKWZn0jy+LlBj7pnUD3s/Exa4/9St0h64Ll/g0KQ dAf0T4qajiIljjJICcNlTzwoketYubIsrqoOOmkiAw43Ucelom4DVHrM9ZCIf25ezn/y 3o8h851xjLMvMHPHeI8juQA/7jyuKSaopN7Z+92PmquuikGyDkdDeyklPZAp7zGoQrjH 5zSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705076326; x=1705681126; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kGo5Qib9p/CMqmc2qVWW+nsxV9z3k+DvCQknh7gy4Ww=; b=qgBv4QK40otCpu/QP79c6B5IeuRDuHP6bWgliNzvKVxJWKAq378pLDPF57nK4EuwaQ ojqK8qJmLeeuaV0CCZCwsHe8l7UH1ZetU+RA6x5DYEA8lc5CRNFccmL2ptiBjQP+Dwms Im5SBpp8cSJJ6SlXf4jhQQ9D5d4iL0/oEM/J1D5CBFIsIau5wNI1KLPbZqfRZ8q7G5/u IrLLoive5JcZ6Kz9OLjtZNwSlHvQtyupiNiUxT65jYYFF2ilJKup40VReZgfaL4Jfpa1 fc5ySbRCTetmWrgePDPTAPoWUGoNiAkSttdBR3rDfHTcTkOK7O4evZUVJhIFfq6uqU7c WWMg== X-Gm-Message-State: AOJu0YzTgKME1XdIZWqOIFmPwsJPCJ2teHr19gPLZLimq3bLbdjheGXy IyyOFlYqhGDMFOq8iq5elYGXafW1Dp/ZPQ== X-Google-Smtp-Source: AGHT+IHOgGtZvSj8dp3Ed1gkngzNUSPm5tUfa1e4J5SEfUWYdU8tbSUFQ/gTEZJG343OrT8yf+lERw== X-Received: by 2002:a05:6602:14c7:b0:7be:edbc:629f with SMTP id b7-20020a05660214c700b007beedbc629fmr2513957iow.0.1705076326471; Fri, 12 Jan 2024 08:18:46 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id s23-20020a02c517000000b0046d98c3cd7bsm964739jam.14.2024.01.12.08.18.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jan 2024 08:18:45 -0800 (PST) Message-ID: Date: Fri, 12 Jan 2024 09:18:44 -0700 Precedence: bulk X-Mailing-List: kernel-janitors@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] io_uring: Delete a redundant kfree() call in io_ring_ctx_alloc() Content-Language: en-US To: Gabriel Krisman Bertazi , Markus Elfring Cc: io-uring@vger.kernel.org, kernel-janitors@vger.kernel.org, Pavel Begunkov , LKML References: <6cbcf640-55e5-2f11-4a09-716fe681c0d2@web.de> <878r4xnn52.fsf@mailhost.krisman.be> <87jzoek4r7.fsf@mailhost.krisman.be> From: Jens Axboe In-Reply-To: <87jzoek4r7.fsf@mailhost.krisman.be> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/12/24 7:25 AM, Gabriel Krisman Bertazi wrote: > Markus Elfring writes: > >> From: Markus Elfring >> Date: Wed, 10 Jan 2024 20:54:43 +0100 >> >> Another useful pointer was not reassigned to the data structure member >> ?io_bl? by this function implementation. >> Thus omit a redundant call of the function ?kfree? at the end. This is just nonsense... On top of that, this patch is pointless, and the 2nd patch is even worse in that it just makes a mess of cleanup. And for what reasoning? Absolutely none. There's a reason why I filter emails from this particular author straight to the trash, there's a long history of this kind of thing and not understanding feedback. -- Jens Axboe