From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BA08352FC7; Tue, 9 Sep 2025 14:30:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757428217; cv=none; b=LOgz/iKrOMe6/jPewcxWajUKHYTY7t2Fe78N4tyilQKKk29ghSNKrt1aXksDvUVuB2czmfG79M/TGhufaMrvwdCUqyUKKrmZBgjcORTjvzWZCbrTKA9KRc/U8F7UY++2xrHirIX3Mp9GmAEr8cLQKoZUUbq9gDyuYXZq6U92EEk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757428217; c=relaxed/simple; bh=oOW/q/nXt3plb1YUm8fTu8X+dc7ZimOQs2RP9TN6Yec=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i3Qf3PK59KGhVu1Z9BK1SB9o0ZwvlfKsWpYwyutIkMsrBNmMpm/QP5vTu2cEnTwK/CXCTxC7Hbr3gLG4DC3aHyuR1EyJVVWTKJJdae977rZLkxakva3fbOTTQE+TIIYqd6mNTJdBm1URgEzk/KoC0PyenwcT+iiOEKj6sMf0Jmo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gfOh/uVn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gfOh/uVn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A66AAC4CEFE; Tue, 9 Sep 2025 14:30:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757428216; bh=oOW/q/nXt3plb1YUm8fTu8X+dc7ZimOQs2RP9TN6Yec=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gfOh/uVnJxQMDBxHVa4QaA+XiK7yWaBbmp9+iWaGTcmFkeFB02wgP6j66f397fuc7 5VN5RqzK8PuWvSdVLwit4X0FAt876HpU1I4PZ2Umcv3kLeRyNGAHl9djOxLNRzSLmc QNLBqcUMrxPzBhOHMnhERtE0zyLOqSRCKCrq1BvQPD0/b3p8/n9YcWKtcQTNevBWSV /paTF/5Rb+/iNdM3iFcuobgNfHv3HWBFXqCTtY/fZwu7+YNlZcJQ5zCOXDf2nGjprO JuXNCFFllglB6Wmv6F1hW6F+Zwmg1skKYolKeg+75q2/6GATUcNjZUC2fYO6yr8ufc AKB/PP1AvAM9w== Message-ID: Date: Tue, 9 Sep 2025 23:30:13 +0900 Precedence: bulk X-Mailing-List: kernel-janitors@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH next] PM / devfreq: Fix double free in devfreq_event_add_edev() To: Dan Carpenter , Kaushlendra Kumar Cc: Chanwoo Choi , MyungJoo Ham , Kyungmin Park , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: From: Chanwoo Choi Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 25. 9. 9. 19:29에 Dan Carpenter 이(가) 쓴 글: > The put_device() function calls devfreq_event_release_edev() which frees > "evdev". Calling kfree() again is a double free. > > Fixes: 430a1845c804 ("PM / devfreq: Fix memory leak in devfreq_event_add_edev()") > Signed-off-by: Dan Carpenter > --- > drivers/devfreq/devfreq-event.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/devfreq/devfreq-event.c b/drivers/devfreq/devfreq-event.c > index 34406c52b845..70219099c604 100644 > --- a/drivers/devfreq/devfreq-event.c > +++ b/drivers/devfreq/devfreq-event.c > @@ -328,7 +328,6 @@ struct devfreq_event_dev *devfreq_event_add_edev(struct device *dev, > ret = device_register(&edev->dev); > if (ret < 0) { > put_device(&edev->dev); > - kfree(edev); > return ERR_PTR(ret); > } > dev_set_drvdata(&edev->dev, edev); Firstly, I'm sorry that it my wrong review of patch[1]. [1] https://patchwork.kernel.org/project/linux-pm/patch/20250907113302.3353584-1-kaushlendra.kumar@intel.com/ As you mentioned, the above patch[1] doesn't be necessary. Instead of applying your patch, I'll drop the patch[1]. I'm sorry to make the confusion. -- Best Regards, Samsung Electronics Chanwoo Choi