Re: [PATCH] x86/platform/UV: make functions uv_handle_nmi and uv_nmi_setup_common static

Ingo Molnar
2017-12-06T17:15:15Z

* Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
>
> Functions uv_handle_nmi and uv_nmi_setup_common are local to the
> source and do not need to be in global scope, so make them static.
>
> Cleans up sparse warnings:
> symbol 'uv_handle_nmi' was not declared. Should it be static?
> symbol 'uv_nmi_setup_common' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> arch/x86/platform/uv/uv_nmi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Please combine your three pending x86 Sparse fix patches (this one, the x86/vector
one and the x86/mm one) into a single patch. They are trivial and should not be
split into 3 patches.

Thanks,

Ingo