* [PATCH] [PATCH] Staging: iio: cdc: ad7152.c, use octal permissions instead of symbolic
@ 2017-03-14 15:52 Miguel Robles
2017-03-15 22:01 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Miguel Robles @ 2017-03-14 15:52 UTC (permalink / raw)
To: jic23, gregkh; +Cc: linux-iio, kernel-janitors, Miguel Robles
Fix checkpatch warnings:
Symbolic permissions are not preferred. Consider using octal permissions.
Signed-off-by: Miguel Robles <miguel.robles@farole.net>
---
drivers/staging/iio/cdc/ad7152.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
index e8609b8..dd0c24c 100644
--- a/drivers/staging/iio/cdc/ad7152.c
+++ b/drivers/staging/iio/cdc/ad7152.c
@@ -155,13 +155,13 @@ static ssize_t ad7152_start_gain_calib(struct device *dev,
}
static IIO_DEVICE_ATTR(in_capacitance0_calibbias_calibration,
- S_IWUSR, NULL, ad7152_start_offset_calib, 0);
+ 0200, NULL, ad7152_start_offset_calib, 0);
static IIO_DEVICE_ATTR(in_capacitance1_calibbias_calibration,
- S_IWUSR, NULL, ad7152_start_offset_calib, 1);
+ 0200, NULL, ad7152_start_offset_calib, 1);
static IIO_DEVICE_ATTR(in_capacitance0_calibscale_calibration,
- S_IWUSR, NULL, ad7152_start_gain_calib, 0);
+ 0200, NULL, ad7152_start_gain_calib, 0);
static IIO_DEVICE_ATTR(in_capacitance1_calibscale_calibration,
- S_IWUSR, NULL, ad7152_start_gain_calib, 1);
+ 0200, NULL, ad7152_start_gain_calib, 1);
/* Values are Update Rate (Hz), Conversion Time (ms) + 1*/
static const unsigned char ad7152_filter_rate_table[][2] = {
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [PATCH] Staging: iio: cdc: ad7152.c, use octal permissions instead of symbolic
2017-03-14 15:52 [PATCH] [PATCH] Staging: iio: cdc: ad7152.c, use octal permissions instead of symbolic Miguel Robles
@ 2017-03-15 22:01 ` Jonathan Cameron
2017-03-15 23:09 ` Miguel Robles
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2017-03-15 22:01 UTC (permalink / raw)
To: Miguel Robles, gregkh; +Cc: linux-iio, kernel-janitors
On 14/03/17 15:52, Miguel Robles wrote:
> Fix checkpatch warnings:
> Symbolic permissions are not preferred. Consider using octal permissions.
>
> Signed-off-by: Miguel Robles <miguel.robles@farole.net>
Thanks,
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/staging/iio/cdc/ad7152.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
> index e8609b8..dd0c24c 100644
> --- a/drivers/staging/iio/cdc/ad7152.c
> +++ b/drivers/staging/iio/cdc/ad7152.c
> @@ -155,13 +155,13 @@ static ssize_t ad7152_start_gain_calib(struct device *dev,
> }
>
> static IIO_DEVICE_ATTR(in_capacitance0_calibbias_calibration,
> - S_IWUSR, NULL, ad7152_start_offset_calib, 0);
> + 0200, NULL, ad7152_start_offset_calib, 0);
> static IIO_DEVICE_ATTR(in_capacitance1_calibbias_calibration,
> - S_IWUSR, NULL, ad7152_start_offset_calib, 1);
> + 0200, NULL, ad7152_start_offset_calib, 1);
> static IIO_DEVICE_ATTR(in_capacitance0_calibscale_calibration,
> - S_IWUSR, NULL, ad7152_start_gain_calib, 0);
> + 0200, NULL, ad7152_start_gain_calib, 0);
> static IIO_DEVICE_ATTR(in_capacitance1_calibscale_calibration,
> - S_IWUSR, NULL, ad7152_start_gain_calib, 1);
> + 0200, NULL, ad7152_start_gain_calib, 1);
>
> /* Values are Update Rate (Hz), Conversion Time (ms) + 1*/
> static const unsigned char ad7152_filter_rate_table[][2] = {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [PATCH] Staging: iio: cdc: ad7152.c, use octal permissions instead of symbolic
2017-03-15 22:01 ` Jonathan Cameron
@ 2017-03-15 23:09 ` Miguel Robles
0 siblings, 0 replies; 3+ messages in thread
From: Miguel Robles @ 2017-03-15 23:09 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: gregkh, linux-iio, kernel-janitors
On Wed, Mar 15, 2017 at 10:01:58PM +0000, Jonathan Cameron wrote:
> On 14/03/17 15:52, Miguel Robles wrote:
> > Fix checkpatch warnings:
> > Symbolic permissions are not preferred. Consider using octal permissions.
> >
> > Signed-off-by: Miguel Robles <miguel.robles@farole.net>
> Thanks,
>
> Applied to the togreg branch of iio.git and pushed out as testing for
> the autobuilders to play with it.
>
> Thanks,
Great, thank you for applying my first patch :)!
Miguel.
>
> Jonathan
> > ---
> > drivers/staging/iio/cdc/ad7152.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
> > index e8609b8..dd0c24c 100644
> > --- a/drivers/staging/iio/cdc/ad7152.c
> > +++ b/drivers/staging/iio/cdc/ad7152.c
> > @@ -155,13 +155,13 @@ static ssize_t ad7152_start_gain_calib(struct device *dev,
> > }
> >
> > static IIO_DEVICE_ATTR(in_capacitance0_calibbias_calibration,
> > - S_IWUSR, NULL, ad7152_start_offset_calib, 0);
> > + 0200, NULL, ad7152_start_offset_calib, 0);
> > static IIO_DEVICE_ATTR(in_capacitance1_calibbias_calibration,
> > - S_IWUSR, NULL, ad7152_start_offset_calib, 1);
> > + 0200, NULL, ad7152_start_offset_calib, 1);
> > static IIO_DEVICE_ATTR(in_capacitance0_calibscale_calibration,
> > - S_IWUSR, NULL, ad7152_start_gain_calib, 0);
> > + 0200, NULL, ad7152_start_gain_calib, 0);
> > static IIO_DEVICE_ATTR(in_capacitance1_calibscale_calibration,
> > - S_IWUSR, NULL, ad7152_start_gain_calib, 1);
> > + 0200, NULL, ad7152_start_gain_calib, 1);
> >
> > /* Values are Update Rate (Hz), Conversion Time (ms) + 1*/
> > static const unsigned char ad7152_filter_rate_table[][2] = {
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-15 23:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-14 15:52 [PATCH] [PATCH] Staging: iio: cdc: ad7152.c, use octal permissions instead of symbolic Miguel Robles
2017-03-15 22:01 ` Jonathan Cameron
2017-03-15 23:09 ` Miguel Robles
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox