From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Simmons, James A." Date: Fri, 01 May 2015 22:57:45 +0000 Subject: RE: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree Message-Id: List-Id: References: <1430495482-933-1-git-send-email-Julia.Lawall@lip6.fr> <1430495482-933-11-git-send-email-Julia.Lawall@lip6.fr> <524505df3433441494cf082a425f2ee7@EXCHCS32.ornl.gov> <20150501204729.GA2265@kroah.com> In-Reply-To: <20150501204729.GA2265@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: 'Greg Kroah-Hartman' Cc: 'Julia Lawall' , "devel@driverdev.osuosl.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Oleg Drokin , "HPDD-discuss@lists.01.org" >> Yes the LARGE functions do the switching. I was expecting also patches to remove the >> OBD_ALLOC_LARGE functions as well which is not the case here. I do have one question still. The >> macro __OBD_MALLOC_VERBOSE allowed the ability to simulate memory allocation failures at >> a certain percentage rate. Does something exist in the kernel to duplicate that functionality? > >Yes, no need for lustre to duplicate yet-another-thing the kernel >already provides :) The reason for this is that libcfs was written 10+ years ago which was before linux had such nice features. At that time it was needed to fill the gaps missing which is no longer the case. Libcfs is really showing its age :-)