Re: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree

Drokin, Oleg
2015-05-03T03:12:31Z

Hello!

On May 2, 2015, at 4:14 AM, Dan Carpenter wrote:

> On Fri, May 01, 2015 at 09:13:11PM +0000, Drokin, Oleg wrote:
>>>> The patch was submitted.
>>>> But it depends on a symbol that's not exported.
>>>> I was not able to change that.
>>>> http://www.spinics.net/lists/linux-mm/msg83997.html
>>>
>>> But you were given a hint on how to change that :)
>>
>> Well, the hint amounted to "don't do vmalloc if you cannot live with the
>> GFP_KERNEL" allocations.
>>
>
> Which email is that?

Ah, my memory is playing tricks, it appears.
There was just a pointer to the "other discussions" where this advice was given it appears.

> I only see where David says to implement vmalloc_node_gfp() and the talk
> was about if that makes sense from a style perspective and then dies.
>
> Anyway, this only seems to affect ptlrpc_alloc_rqbd() since I think
> that's the only place which calls OBD_CPT_ALLOC_PTR(). The rest can use
> __vmalloc().

I guess so.

Bye,
Oleg