From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Ojha Date: Thu, 04 Apr 2019 10:28:09 +0000 Subject: Re: [PATCH] staging: rtl8192u: remove redundant null check on array 'data' Message-Id: List-Id: References: <20190404093257.18757-1-colin.king@canonical.com> In-Reply-To: <20190404093257.18757-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King , Greg Kroah-Hartman , John Whitmore , devel@driverdev.osuosl.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On 4/4/2019 3:02 PM, Colin King wrote: > From: Colin Ian King > > The NULL check on ram->u.wpa_ie.data is redudant as data is s/redudant/redundant > zero-length array and is not a pointer, so it can't be null. > Remove the check. > > Addresses-Coverity: ("Array compared against 0") > Signed-off-by: Colin Ian King fix the commit text minor err Reviewed-by: Mukesh Ojha Cheers, -Mukesh > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > index 944c8894f9ff..c4a4f118f547 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > @@ -2659,8 +2659,7 @@ static int ieee80211_wpa_set_wpa_ie(struct ieee80211_device *ieee, > { > u8 *buf; > > - if (param->u.wpa_ie.len > MAX_WPA_IE_LEN || > - (param->u.wpa_ie.len && param->u.wpa_ie.data = NULL)) > + if (param->u.wpa_ie.len > MAX_WPA_IE_LEN || param->u.wpa_ie.len) > return -EINVAL; > > if (param->u.wpa_ie.len) {