From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 23 May 2017 16:23:17 +0000 Subject: Re: tipc: Delete error messages for failed memory allocations in three functions Message-Id: List-Id: References: <7ac9d513-6f9f-a096-e68f-81a722c2723c@users.sourceforge.net> <1495548133.2093.58.camel@perches.com> In-Reply-To: <1495548133.2093.58.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joe Perches , tipc-discussion@lists.sourceforge.net, netdev@vger.kernel.org Cc: "David S. Miller" , Jon Maloy , Ying Xue , LKML , kernel-janitors@vger.kernel.org > tipc_subseq_alloc does a kcalloc (memset to 0), > half of which is immediately overwritten. > > In other words, don't just blindly remove stuff, > understand what it does and improve it. Do you suggest another specific source code transformation pattern here? Regards, Markus