From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Date: Mon, 28 Aug 2017 20:23:38 +0000 Subject: Re: [PATCH] leds-PowerNV: Delete an error message for a failed memory allocation in powernv_led_crea Message-Id: List-Id: References: <019499e0-68d8-b89d-f5d6-6aefd9cbaf04@users.sourceforge.net> In-Reply-To: <019499e0-68d8-b89d-f5d6-6aefd9cbaf04@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring , linux-leds@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras , Pavel Machek , Richard Purdie Cc: LKML , kernel-janitors@vger.kernel.org Hi Markus, Thanks for the patch. On 08/27/2017 10:10 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 27 Aug 2017 22:00:22 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/leds/leds-powernv.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/leds/leds-powernv.c b/drivers/leds/leds-powernv.c > index b2a98c7b521b..b1adbd70ce2e 100644 > --- a/drivers/leds/leds-powernv.c > +++ b/drivers/leds/leds-powernv.c > @@ -224,12 +224,8 @@ static int powernv_led_create(struct device *dev, > powernv_led->cdev.name = devm_kasprintf(dev, GFP_KERNEL, "%s:%s", > powernv_led->loc_code, > led_type_desc); > - if (!powernv_led->cdev.name) { > - dev_err(dev, > - "%s: Memory allocation failed for classdev name\n", > - __func__); > + if (!powernv_led->cdev.name) > return -ENOMEM; > - } > > powernv_led->cdev.brightness_set_blocking = powernv_brightness_set; > powernv_led->cdev.brightness_get = powernv_brightness_get; > Applied. -- Best regards, Jacek Anaszewski