From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Date: Thu, 05 Oct 2017 19:31:58 +0000 Subject: Re: [PATCH] net: qcom/emac: make function emac_isr static Message-Id: List-Id: References: <20171005091023.27781-1-colin.king@canonical.com> In-Reply-To: <20171005091023.27781-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On 10/05/2017 04:10 AM, Colin King wrote: > From: Colin Ian King > > The function emac_isr is local to the source and does not need to > be in global scope, so make it static. > > Cleans up sparse warnings: > symbol 'emac_isr' was not declared. Should it be static? > > Signed-off-by: Colin Ian King ACK -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.