From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Tariq Toukan <tariqt@mellanox.com>,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org
Cc: Julia Lawall <julia.lawall@lip6.fr>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: ethernet: mlx4: Delete an error message for a failed memory allocation in five functions
Date: Wed, 03 Jan 2018 14:22:03 +0000 [thread overview]
Message-ID: <d693dbdb-f3a2-5194-07e9-7c56e9ccbb2b@users.sourceforge.net> (raw)
In-Reply-To: <adfc3229-d3f9-afb9-00e6-9f765af0cbe8@mellanox.com>
> I don't really accept this claim...
> Short informative strings worth the tiny space they consume.
There can be different opinions for their usefulness.
> In addition, some out-of-memory errors are recoverable, even though their backtrace is also printed.
How do you think about to suppress the backtrace generation for them?
> For example, in function mlx4_en_create_cq (appears in patch) we have a first allocation attempt (kzalloc_node)
Would it be helpful to pass the option “__GFP_NOWARN” there?
> and a fallback (kzalloc). I'd prefer to state a clear error message only when both have failed,
> because otherwise the user might be confused whether the backtrace should indicate a malfunctioning interface, or not.
Can the distinction become easier by any other means?
Regards,
Markus
next prev parent reply other threads:[~2018-01-03 14:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-01 20:46 [PATCH] ethernet: mlx4: Delete an error message for a failed memory allocation in five functions SF Markus Elfring
2018-01-03 7:58 ` Tariq Toukan
2018-01-03 8:06 ` Julia Lawall
2018-01-03 11:24 ` Tariq Toukan
2018-01-03 14:17 ` Leon Romanovsky
2018-01-03 14:22 ` SF Markus Elfring [this message]
2018-01-04 9:24 ` Tariq Toukan
2018-01-03 16:03 ` [PATCH] " Jason Gunthorpe
[not found] ` <30191db0-4d99-0349-b66a-c7354ef90d50-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2018-01-04 9:28 ` Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d693dbdb-f3a2-5194-07e9-7c56e9ccbb2b@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox