From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Wed, 03 Jan 2018 14:22:03 +0000 Subject: Re: ethernet: mlx4: Delete an error message for a failed memory allocation in five functions Message-Id: List-Id: References: <30191db0-4d99-0349-b66a-c7354ef90d50@users.sourceforge.net> <0fea8f2f-f8fc-ce2e-3d33-44227de3637a@mellanox.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Tariq Toukan , linux-rdma@vger.kernel.org, netdev@vger.kernel.org Cc: Julia Lawall , LKML , kernel-janitors@vger.kernel.org > I don't really accept this claim... > Short informative strings worth the tiny space they consume. There can be different opinions for their usefulness. > In addition, some out-of-memory errors are recoverable, even though their backtrace is also printed. How do you think about to suppress the backtrace generation for them? > For example, in function mlx4_en_create_cq (appears in patch) we have a first allocation attempt (kzalloc_node) Would it be helpful to pass the option “__GFP_NOWARN” there? > and a fallback (kzalloc). I'd prefer to state a clear error message only when both have failed, > because otherwise the user might be confused whether the backtrace should indicate a malfunctioning interface, or not. Can the distinction become easier by any other means? Regards, Markus