public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Colin Ian King <colin.i.king@gmail.com>,
	ocfs2-devel@lists.linux.dev, Joel Becker <jlbec@evilplan.org>,
	Joseph Qi <joseph.qi@linux.alibaba.com>,
	Mark Fasheh <mark@fasheh.com>
Cc: kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ocfs2: Remove space before newline
Date: Tue, 29 Jul 2025 14:21:59 +0200	[thread overview]
Message-ID: <d72608fc-b385-46c2-b0bf-bd78b2a8acc0@web.de> (raw)
In-Reply-To: <20250729114131.1925586-1-colin.i.king@gmail.com>

…
> Remove it

  Thus delete a redundant character.?


…
> +++ b/fs/ocfs2/super.c
> @@ -2108,7 +2108,7 @@ static int ocfs2_initialize_super(struct super_block *sb,
>  		if (strlen(osb->osb_cluster_stack) != OCFS2_STACK_LABEL_LEN) {
>  			mlog(ML_ERROR,
>  			     "couldn't mount because of an invalid "
> -			     "cluster stack label (%s) \n",
> +			     "cluster stack label (%s)\n",
>  			     osb->osb_cluster_stack);
…

You may recombine such string literals.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.16#n116

Regards,
Markus

      reply	other threads:[~2025-07-29 12:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-29 11:41 [PATCH][next] ocfs2: Remove space before newline Colin Ian King
2025-07-29 12:21 ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d72608fc-b385-46c2-b0bf-bd78b2a8acc0@web.de \
    --to=markus.elfring@web.de \
    --cc=colin.i.king@gmail.com \
    --cc=jlbec@evilplan.org \
    --cc=joseph.qi@linux.alibaba.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark@fasheh.com \
    --cc=ocfs2-devel@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox