From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 5/6] lockdep: Improve a size determination in lock_stat_open()
Date: Wed, 03 May 2017 20:40:51 +0000 [thread overview]
Message-ID: <d8ceba55-646a-e0ac-1c1a-8178b79d3200@users.sourceforge.net> (raw)
In-Reply-To: <3f95acb5-c037-b6fa-7a9b-258b4ae465fb@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 3 May 2017 22:05:57 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
kernel/locking/lockdep_proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/locking/lockdep_proc.c b/kernel/locking/lockdep_proc.c
index 2cc0ccd2b3de..509a17f5ea01 100644
--- a/kernel/locking/lockdep_proc.c
+++ b/kernel/locking/lockdep_proc.c
@@ -607,7 +607,7 @@ static int lock_stat_open(struct inode *inode, struct file *file)
{
int res;
struct lock_class *class;
- struct lock_stat_seq *data = vmalloc(sizeof(struct lock_stat_seq));
+ struct lock_stat_seq *data = vmalloc(sizeof(*data));
if (!data)
return -ENOMEM;
--
2.12.2
next prev parent reply other threads:[~2017-05-03 20:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 20:35 [PATCH 0/6] lockdep: Fine-tuning for some function implementations SF Markus Elfring
2017-05-03 20:36 ` [PATCH 1/6] lockdep: Replace 11 seq_puts() calls by seq_putc() SF Markus Elfring
2017-05-03 20:37 ` [PATCH 2/6] lockdep: Use seq_putc() in seq_header() SF Markus Elfring
2017-05-03 20:38 ` [PATCH 3/6] lockdep: Replace four seq_printf() calls by seq_puts() SF Markus Elfring
2017-05-03 20:39 ` [PATCH 4/6] lockdep: Combine two seq_printf() calls into one call in l_show() SF Markus Elfring
2017-05-03 20:40 ` SF Markus Elfring [this message]
2017-05-03 20:42 ` [PATCH 6/6] lockdep: Add spaces for better code readability SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8ceba55-646a-e0ac-1c1a-8178b79d3200@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox