From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Date: Mon, 12 Jun 2017 09:04:20 +0000 Subject: Re: [PATCH] drm/mediatek: check for memory allocation failure Message-Id: List-Id: References: <20170609192712.18155-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20170609192712.18155-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET , ck.hu@mediatek.com, p.zabel@pengutronix.de, airlied@linux.ie Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On 09/06/17 21:27, Christophe JAILLET wrote: > If 'devm_kmalloc_array' returns NULL, we should return -ENOMEM as already > done a few lines above instead of deferencing a NULL pointer a few lines > below. > > Signed-off-by: Christophe JAILLET > --- Reviewed-by: Matthias Brugger > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > index 6582e1f56d37..cb32c9369f3a 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > @@ -559,6 +559,8 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, > mtk_crtc->ddp_comp = devm_kmalloc_array(dev, mtk_crtc->ddp_comp_nr, > sizeof(*mtk_crtc->ddp_comp), > GFP_KERNEL); > + if (!mtk_crtc->ddp_comp) > + return -ENOMEM; > > mtk_crtc->mutex = mtk_disp_mutex_get(priv->mutex_dev, pipe); > if (IS_ERR(mtk_crtc->mutex)) { >