From: Markus Elfring <Markus.Elfring@web.de>
To: Dan Carpenter <dan.carpenter@linaro.org>,
linux-efi@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>, Jeremy Kerr <jk@ozlabs.org>
Subject: Re: [PATCH next] efivarfs: Fix a NULL vs IS_ERR() bug
Date: Tue, 14 Jan 2025 18:11:01 +0100 [thread overview]
Message-ID: <de667368-baee-46fc-9683-62cc92936e7d@web.de> (raw)
In-Reply-To: <7f7565d8-ef9f-4e5f-834b-9735db01835a@stanley.mountain>
> The kernel_file_open() function doesn't return NULL, it retursn error
returns?
> pointers. Fix the error checking to match.
Regards,
Markus
prev parent reply other threads:[~2025-01-14 17:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 6:15 [PATCH next] efivarfs: Fix a NULL vs IS_ERR() bug Dan Carpenter
2025-01-13 14:18 ` Ard Biesheuvel
2025-01-13 14:25 ` Dan Carpenter
2025-01-14 17:11 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de667368-baee-46fc-9683-62cc92936e7d@web.de \
--to=markus.elfring@web.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=ardb@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=jk@ozlabs.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox