From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.web.de (mout.web.de [212.227.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB02313BC0C; Sun, 9 Feb 2025 11:00:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739098821; cv=none; b=vCct09hsjC6qAeZhyvHnw/HI1eExZQ7wBNd6880pllrm1qOEeKPu2hERerXX5tNlyDNZC76Rz14kMZhlxlvAiXi8j2fhI3V334TiAX3kY/81yXOcnEWt+bajXMh4j5fDWQpCmPT9N7+9Psd5KPovlhkABYKGIlHRULr7nH+G50A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739098821; c=relaxed/simple; bh=uchKxHe/6t1Gucz4FmMs/tY7jNQzjVFaIGS0K7VXSjU=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=NmehvnZGd06zQpiIaZSmPIkaDYJNDcG0ZU4tVhK8CajO6IScVzDW7iHyj2PHbSfmTk0VN4CSEfewBmETjscfs2iIb3jtanlyNkeaPpPbVm1um9v9FN+5nbCIXJ7Rs/BKtDWGLcxEyfguw0G+TQkn559DPaOBefR97Pfo+vMYso8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=JkUbwCqH; arc=none smtp.client-ip=212.227.17.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="JkUbwCqH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1739098812; x=1739703612; i=markus.elfring@web.de; bh=zTTFXhhuzuAGcnouAfDibr4bNX81x1TGXC62o0Kjysk=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=JkUbwCqHQaAXl52/EVdi1ljGmh9spZiC/zg49giAScmn8Lmbgj5UzIriGtVfn+0A 3AKLn5pRNeBX51sfSYVsyoKFfBj9CeJRo8f9ewaLC4OfxRjeTKXzPlxMRojt2emgq 69chWMz6JBmfsxlbYLqnTjUn3T2XSsc84XwdRFw2GCVnYawwR7C6WwLUEvijdtIZs g3vnXyP+WNBn+Lk8YObabbgbU/16Pgu7hJEmDG0wKDwJD/feoPFEjv31evWBcBBon VYbppIuN9cUyr5zJksMJLXUOFDvrIJk6aS5/LExbor9DOVayPKQYURkVwZNtrOsLx wqkx6maeta8BBPa9CQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.29] ([94.31.70.5]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MyNwk-1tSj0y2xKe-017uN8; Sun, 09 Feb 2025 12:00:12 +0100 Message-ID: Date: Sun, 9 Feb 2025 12:00:11 +0100 Precedence: bulk X-Mailing-List: kernel-janitors@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Ethan Carter Edwards , kernel-hardening@lists.openwall.com, linux-hardening@vger.kernel.org, Ingo Molnar Cc: LKML , kernel-janitors@vger.kernel.org, Ben Segall , Peter Zijlstra References: Subject: Re: [PATCH v2] sched/topology: change kzalloc to kcalloc Content-Language: en-GB From: Markus Elfring In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:6VLn2NDmUxJaetn9zKEBY3t2zlEqmfbtGelOKPrXuClPkOEyi+X gGMkbre9CTAauYoztqdq8j0ciqgbRHSb2VMz/dzBGjxM9KuAiJ+D6PGUXsTAspq6XmxWC0z ILl5jdCg4zfYUBMgFTPCMUuYYXm2QFSvV68ii9VKJfkhqv4DGIxeHCZWo7vOcM2y4cHDVyY RqXPUyXtxL9ANVHzJbhug== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:8oCHxsTpdIs=;dwECqzLvlQ2np28+V4Z733uGZsX 3jqs8Nme6dbgp/a94OcBg2dAA9cF2PE7/3e63RwGDWL7JbsjWOjvglE3HRBmyGx9Ym4HQLife HDK7wjKQ8/NpT1uf8iAmVHnwZ4k+ppsF4JMkRMLyKRxU7c1v1Z6Kw1wUFdj/BL3bZ2kaYiuov 0fxuhFdsxoBUfslAWm0zWhaeZrJAg4V9DhJcF29Qs5fV1YPJ6rD+yyKyDyczJOt9E8TFdtmXy qF8CTrXAQW6BpMUivtx7WOjb1MNddSuhBII+bqNYaoKnbbjEaS0yohw51PjGu79BGQgCSMH8y DzuaIhE3KlU16manOVrCi+0CdcYZIBzVL1fEXnoFXNYgzrPQPWjcu79nCmvuEV45019FXHZYa TFe6XrB6EO37yp6nav75vxluw4AONOBg4kSLEEiFS1LJGpRehXme8RqFscOia+rvDcJvFCnvC a25hRIf01l+R3k+m8zQAb5/t6AWbv03THfbmVG+Ddc5KlnWg7Lr7xpaIJFCi0J4yeXvx9uCc2 NKUYOmjr0iA942zInzddqXxHJiCazjQ0pCQCPEEoNe8mi0dlN3jY/4jXeb5Z56h4kVaWgvrVY pzqHOGwdZbCE+JzNlfq3Pn5ZRq3jDfHzV39m/W92TT3MNBEgLAfBtpPhsjS+8knTrNl99ZXR0 abVtV12V1SfIHidBBvc/yvsld/dqTXu7+aey+7FXlyBG2TxjEiACjkfTee7e6VuaNfeu9kqAD Yv/zK2eWuDCQYKRPAH12nda7rn7bEHr3NDypkIqVMfL4HBir5Mo4iPnasiusWQbqu3JvwM902 NCU9AQZ1FvyKbXDg4gBnFVpujUYF3MiYzJcnctIYo2Mn/304CCgCp7czrsGJ2Djw8wEF5w+CJ 3Pu+w0RJfYBK1gs8z3EkTD/h6eF0SE2a7y1DxegNLglWrDAgLGHHrvMN9lEaVRCH6J5XRxDLU o1/Qcjz5hf1RD6A5+1WoAArxwQSMVS6xmi8Qc3mX0VHJa3+vgjf1N5YbdXliSV5QLpZCRBomh s4Gef0CEOxZKEN/Z+vCedFLFCFoSt5tlhknGcS8IUAxXCKECmY6Z6vVV2/ns4l/4U2AkAxbJB kzJGhaoxU28PXB8EvuBHY/chblWxDj6mQ9UWVDSJKSMTjLdQpA3NdghHj7erkILT1VHRDkaak 4HJ5Y/RX5KIai6jt7tPFsrGUhVYrcEulGsJtTGUy6mfaXkrhkArZkl0W38Zc8cOQrDXIpp5qA 1jy1xFUzwSW9nSqSrvw6332k83VSOfyqB/WFC4UHSonT/ZqQQOHzlFfbk7JmEaoxyDIXNNCXb eUd971cZBygRXO3hCVja7trd+/KjqsoaZT1DqZrvP9MN9Pkbf038QKRIPFwCp0lRuHhKch2Pi Sa0HixxWxwzZGo+C4q9c5Z4isp9hihrwpoeKOWr++54Zfw4Pkm6g0j8SVTYuHVdAdpBKfa8Xn ZqEz9yDNTvnY2IaxU8vJ/olgmO0E= > We are replacing any instances of kzalloc(size * count, ...) with > kcalloc(count, size, ...) due to risk of overflow [1]. * See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/= Documentation/process/submitting-patches.rst?h=3Dv6.13#n94 * How do you think about to use a summary phrase like =E2=80=9CReplace two= kzalloc() calls by kcalloc() in sched_init_numa()=E2=80=9D? * Would you be looking for any coccicheck extensions accordingly? Regards, Markus