public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: shuah <shuah@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Valentina Manea <valentina.manea.m@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org,
	shuah <shuah@kernel.org>
Subject: Re: [PATCH] usbip: stub_rx: tidy the indenting in is_clear_halt_cmd()
Date: Thu, 25 Apr 2019 23:09:43 +0000	[thread overview]
Message-ID: <e13158e8-296f-bcef-eb03-0ef0ef735a1d@kernel.org> (raw)
In-Reply-To: <20190424095414.GB16664@mwanda>

On 4/24/19 3:54 AM, Dan Carpenter wrote:
> There is an extra space character before the return statement.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/usb/usbip/stub_rx.c b/drivers/usb/usbip/stub_rx.c
> index 97b09a42a10c..f3230bed18af 100644
> --- a/drivers/usb/usbip/stub_rx.c
> +++ b/drivers/usb/usbip/stub_rx.c
> @@ -17,9 +17,9 @@ static int is_clear_halt_cmd(struct urb *urb)
>   
>   	req = (struct usb_ctrlrequest *) urb->setup_packet;
>   
> -	 return (req->bRequest = USB_REQ_CLEAR_FEATURE) &&
> -		 (req->bRequestType = USB_RECIP_ENDPOINT) &&
> -		 (req->wValue = USB_ENDPOINT_HALT);
> +	return (req->bRequest = USB_REQ_CLEAR_FEATURE) &&
> +	       (req->bRequestType = USB_RECIP_ENDPOINT) &&
> +	       (req->wValue = USB_ENDPOINT_HALT);
>   }
>   
>   static int is_set_interface_cmd(struct urb *urb)
> 

Thanks for the patch.

Acked-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah

      reply	other threads:[~2019-04-25 23:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24  9:54 [PATCH] usbip: stub_rx: tidy the indenting in is_clear_halt_cmd() Dan Carpenter
2019-04-25 23:09 ` shuah [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e13158e8-296f-bcef-eb03-0ef0ef735a1d@kernel.org \
    --to=shuah@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=valentina.manea.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox