From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Tue, 12 Mar 2019 06:35:30 +0000 Subject: Re: [PATCH net] staging: rtl8188eu: use is_zero_ether_addr() instead of memcmp() Message-Id: List-Id: References: <20190309032600.98732-1-maowenan@huawei.com> <951c83d2-fa0d-11ed-96a9-cee620c9c096@huawei.com> In-Reply-To: <951c83d2-fa0d-11ed-96a9-cee620c9c096@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: maowenan , Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org, straube.linux@gmail.com, jananis37@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, davem@davemloft.net On Tue, 2019-03-12 at 14:29 +0800, maowenan wrote: > ping... > > On 2019/3/9 11:26, Mao Wenan wrote: > > Using is_zero_ether_addr() instead of directly use > > memcmp() to determine if the ethernet address is all > > zeros. [] > > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c [] > > @@ -180,9 +180,8 @@ struct wlan_network *rtw_find_network(struct __queue *scanned_queue, u8 *addr) > > { > > struct list_head *phead, *plist; > > struct wlan_network *pnetwork = NULL; > > - u8 zero_addr[ETH_ALEN] = {0, 0, 0, 0, 0, 0}; > > > > - if (!memcmp(zero_addr, addr, ETH_ALEN)) { > > + if (is_zero_ether_addr(addr)) { How did you verify that addr is __aligned(2)?