From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Mon, 22 May 2017 11:34:34 +0000 Subject: Re: vhost/scsi: Delete error messages for failed memory allocations in five functions Message-Id: List-Id: References: <20170522094320.GE12205@stefanha-x1.localdomain> <557bdff4-6dc2-756d-0d59-9f688ef11f0a@users.sourceforge.net> <20170522112320.GA22806@stefanha-x1.localdomain> In-Reply-To: <20170522112320.GA22806@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Stefan Hajnoczi Cc: kvm@vger.kernel.org, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, kernel-janitors@vger.kernel.org, Jason Wang , "Michael S. Tsirkin" , LKML , Wolfram Sang >> Do you find information from a Linux allocation failure report sufficient >> for any function implementations here? > > If kmalloc() and friends guarantee to print a warning and backtrace on > every allocation failure, then there's no need for error messages in > callers. > > That seems like good justification that can go in the commit > description, but I'm not sure if kmalloc() and friends guarantee to show > a message (not just the first time, but for every failed allocation)? I am also looking for a more complete and easier accessible documentation for this aspect of the desired exception handling. How would we like to resolve any remaining open issues there? Regards, Markus