From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Dan Carpenter <dan.carpenter@oracle.com>, linux-doc@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] char/snsc: Delete unnecessary braces in five functions
Date: Tue, 17 Oct 2017 09:11:20 +0000 [thread overview]
Message-ID: <e713a84d-ea1d-0623-d45d-d1cdc52583d9@users.sourceforge.net> (raw)
In-Reply-To: <20171017084919.oa462je5y45otrw7@mwanda>
>> /* ...or if we want to block, then do so here */
>> - if (down_interruptible(&sd->sd_wbs)) {
>> + if (down_interruptible(&sd->sd_wbs))
>> /* something went wrong with wait */
>> return -ERESTARTSYS;
>> - }
>> }
>
> Multi-line indents get parenthesis.
How do you think about to add such an expectation to the section
“3) Placing Braces and Spaces” in the document “coding-style.rst”?
Regards,
Markus
prev parent reply other threads:[~2017-10-17 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 15:02 [PATCH 0/4] char-SNSC: Adjustments for six function implementations SF Markus Elfring
2017-10-16 15:04 ` [PATCH 1/4] char/snsc: Adjust one function call together with a variable assignment SF Markus Elfring
2017-10-16 15:05 ` [PATCH 2/4] char/snsc: Delete three error messages for a failed memory allocation SF Markus Elfring
2017-10-16 15:06 ` [PATCH 3/4] char/snsc: Improve a size determination in two functions SF Markus Elfring
2017-10-16 15:07 ` [PATCH 4/4] char/snsc: Delete unnecessary braces in five functions SF Markus Elfring
2017-10-17 8:49 ` Dan Carpenter
2017-10-17 9:11 ` SF Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e713a84d-ea1d-0623-d45d-d1cdc52583d9@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=arnd@arndb.de \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox