From: Ruben Wauters <rubenru09@aol.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST
Date: Fri, 18 Jul 2025 14:59:10 +0100 [thread overview]
Message-ID: <ea5ac37cfae72d312c47ab1983dd1fcb59edec28.camel@aol.com> (raw)
In-Reply-To: <20250701115511.5445-1-rubenru09@aol.com>
On Tue, 2025-07-01 at 12:54 +0100, Ruben Wauters wrote:
> DRM_DEBUG_SELFTEST was removed in commit fc8d29e298cf (drm: selftest:
> convert drm_mm selftest to KUnit) and all functions under it were
> converted to KUnit, under the DRM_KUNIT_TEST option
>
> This conversion however did not occur in the Kconfig.debug file in
> the
> i915 directory.
>
> This patch replaces the select for DRM_DEBUG_SELFTEST, an option that
> no
> longer exists, with the correct select, DRM_KUNIT_TEST.
>
> Signed-off-by: Ruben Wauters <rubenru09@aol.com>
> ---
> v2 changes:
> - update commit message to contain more detail about the background
> of
> the change and why it is necessary
> ---
> drivers/gpu/drm/i915/Kconfig.debug | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/Kconfig.debug
> b/drivers/gpu/drm/i915/Kconfig.debug
> index 1852e0804942..b15b1cecb3aa 100644
> --- a/drivers/gpu/drm/i915/Kconfig.debug
> +++ b/drivers/gpu/drm/i915/Kconfig.debug
> @@ -50,7 +50,7 @@ config DRM_I915_DEBUG
> select DRM_VGEM # used by igt/prime_vgem (dmabuf interop
> checks)
> select DRM_DEBUG_MM if DRM=y
> select DRM_EXPORT_FOR_TESTS if m
> - select DRM_DEBUG_SELFTEST
> + select DRM_KUNIT_TEST
> select DMABUF_SELFTESTS
> select SW_SYNC # signaling validation framework
> (igt/syncobj*)
> select DRM_I915_WERROR
Hello, I was wondering if it'd be possible to have this patch reviewed.
Having an incorrect Kconfig entry isn't ideal and it'd be good if this
could be fixed if possible
Thanks
Ruben Wauters
next prev parent reply other threads:[~2025-07-18 14:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250701115511.5445-1-rubenru09.ref@aol.com>
2025-07-01 11:54 ` [PATCH v2] drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST Ruben Wauters
2025-07-18 13:59 ` Ruben Wauters [this message]
2025-07-18 16:19 ` Rodrigo Vivi
2025-07-21 14:47 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea5ac37cfae72d312c47ab1983dd1fcb59edec28.camel@aol.com \
--to=rubenru09@aol.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox