Re: [PATCH 26/46] selinux: Improve another size determination in sens_read()

Paul Moore
2017-03-29T14:52:03Z

On Sun, Jan 15, 2017 at 10:26 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 14 Jan 2017 21:52:55 +0100
>
> Replace the specification of a data type by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> security/selinux/ss/policydb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Merged, thanks.

> diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c
> index 5caa1fa5ea80..edfcfd3bbc60 100644
> --- a/security/selinux/ss/policydb.c
> +++ b/security/selinux/ss/policydb.c
> @@ -1609,7 +1609,7 @@ static int sens_read(struct policydb *p, struct hashtab *h, void *fp)
> goto bad;
>
> rc = -ENOMEM;
> - levdatum->level = kmalloc(sizeof(struct mls_level), GFP_ATOMIC);
> + levdatum->level = kmalloc(sizeof(*levdatum->level), GFP_ATOMIC);
> if (!levdatum->level)
> goto bad;
>
> --
> 2.11.0
>

--
paul moore