* [PATCH -next] clk: davinci: Remove redundant dev_err calls
@ 2018-03-22 2:11 Wei Yongjun
2018-03-22 16:28 ` David Lechner
2018-03-23 16:45 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2018-03-22 2:11 UTC (permalink / raw)
To: David Lechner, Sekhar Nori, Michael Turquette, Stephen Boyd
Cc: Wei Yongjun, linux-clk, kernel-janitors
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/clk/davinci/psc.c | 4 +---
drivers/clk/davinci/pll.c | 4 +---
2 file changed, 2 insertion(+), 6 deletions(-)
diff --git a/drivers/clk/davinci/psc.c b/drivers/clk/davinci/psc.c
index 3b0e59d..ff6f4a0 100644
--- a/drivers/clk/davinci/psc.c
+++ b/drivers/clk/davinci/psc.c
@@ -521,10 +521,8 @@ static int davinci_psc_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
base = devm_ioremap_resource(dev, res);
- if (IS_ERR(base)) {
- dev_err(dev, "ioremap failed\n");
+ if (IS_ERR(base))
return PTR_ERR(base);
- }
ret = devm_clk_bulk_get(dev, init_data->num_parent_clks,
init_data->parent_clks);
diff --git a/drivers/clk/davinci/pll.c b/drivers/clk/davinci/pll.c
index 89d30bf..23a24c9 100644
--- a/drivers/clk/davinci/pll.c
+++ b/drivers/clk/davinci/pll.c
@@ -814,10 +814,8 @@ static int davinci_pll_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
base = devm_ioremap_resource(dev, res);
- if (IS_ERR(base)) {
- dev_err(dev, "ioremap failed\n");
+ if (IS_ERR(base))
return PTR_ERR(base);
- }
return pll_init(dev, base);
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] clk: davinci: Remove redundant dev_err calls
2018-03-22 2:11 [PATCH -next] clk: davinci: Remove redundant dev_err calls Wei Yongjun
@ 2018-03-22 16:28 ` David Lechner
2018-03-23 16:45 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: David Lechner @ 2018-03-22 16:28 UTC (permalink / raw)
To: Wei Yongjun, Sekhar Nori, Michael Turquette, Stephen Boyd
Cc: linux-clk, kernel-janitors
On 03/21/2018 09:11 PM, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
Reviewed-by: David Lechner <david@lechnology.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] clk: davinci: Remove redundant dev_err calls
2018-03-22 2:11 [PATCH -next] clk: davinci: Remove redundant dev_err calls Wei Yongjun
2018-03-22 16:28 ` David Lechner
@ 2018-03-23 16:45 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2018-03-23 16:45 UTC (permalink / raw)
To: David Lechner, Michael Turquette, Sekhar Nori, Wei Yongjun
Cc: linux-clk, kernel-janitors
Quoting Wei Yongjun (2018-03-21 19:11:48)
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-23 16:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-22 2:11 [PATCH -next] clk: davinci: Remove redundant dev_err calls Wei Yongjun
2018-03-22 16:28 ` David Lechner
2018-03-23 16:45 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox