From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [media] s5p-mfc: Adjust a null pointer check in four functions
Date: Tue, 12 Sep 2017 17:41:28 +0000 [thread overview]
Message-ID: <ee8ba7fd-1de4-b1b9-8aa0-130c86c38f30@samsung.com> (raw)
In-Reply-To: <5b8eb902-d97c-3308-5ba9-64469320e0e2@users.sourceforge.net>
On 09/12/2017 05:00 PM, SF Markus Elfring wrote:
>>> * Do you care to preserve an information like the author date?
>> In this case not, but actually the Date line is not an issue.
> Thanks for your information.
>
> It seems then that you quoted a line too much.
>
>> Anyway the patch is malformed, …
>
> I have got doubts for this view because the file was automatically generated
> by the command “git format-patch” also for the discussed three update steps.
Generating patch is only part of the story, it seems the patch is not sent
properly and tags which should be in SMTP header end up in the message
body. I think there would not be such issues if you have used git format-patch
+ git send-email.
I normally do amend things like this while applying, I will do that this time
as well. It's already too much time wasted for such a dubious patch.
--
Thanks,
Sylwester
next prev parent reply other threads:[~2017-09-12 17:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 20:50 [PATCH 0/3] S5P MFC: Adjustments for five function implementations SF Markus Elfring
2017-09-08 20:51 ` [PATCH 1/3] [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_probe SF Markus Elfring
2017-09-11 9:14 ` [PATCH 1/3] [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_p Sylwester Nawrocki
2017-09-11 19:34 ` [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_probe() SF Markus Elfring
2017-09-08 20:52 ` [PATCH 2/3] [media] s5p-mfc: Improve a size determination in s5p_mfc_alloc_memdev() SF Markus Elfring
2017-09-11 9:16 ` Sylwester Nawrocki
2017-09-08 20:53 ` [PATCH 3/3] [media] s5p-mfc: Adjust a null pointer check in four functions SF Markus Elfring
2017-09-11 9:21 ` Sylwester Nawrocki
2017-09-11 19:21 ` SF Markus Elfring
2017-09-12 13:21 ` Sylwester Nawrocki
2017-09-12 15:00 ` SF Markus Elfring
2017-09-12 17:41 ` Sylwester Nawrocki [this message]
2017-09-12 20:33 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee8ba7fd-1de4-b1b9-8aa0-130c86c38f30@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox