From: Mukesh Ojha <quic_mojha@quicinc.com>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Steve French <sfrench@samba.org>
Cc: Paulo Alcantara <pc@manguebit.com>,
Ronnie Sahlberg <lsahlber@redhat.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>, <linux-cifs@vger.kernel.org>,
<samba-technical@lists.samba.org>, <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] smb: delete an unnecessary statement
Date: Fri, 26 May 2023 21:06:19 +0530 [thread overview]
Message-ID: <ee9c0ab3-028f-cadf-c577-e57a139de5ce@quicinc.com> (raw)
In-Reply-To: <077d93ae-adbf-4425-9cc4-eea5163b050c@kili.mountain>
On 5/26/2023 5:31 PM, Dan Carpenter wrote:
> We don't need to set the list iterators to NULL before a
> list_for_each_entry() loop because they are assigned inside the
> macro.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
-Mukesh
> ---
> fs/smb/client/smb2ops.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c
> index 5065398665f1..6e3be58cfe49 100644
> --- a/fs/smb/client/smb2ops.c
> +++ b/fs/smb/client/smb2ops.c
> @@ -618,7 +618,6 @@ parse_server_interfaces(struct network_interface_info_ioctl_rsp *buf,
> * Add a new one instead
> */
> spin_lock(&ses->iface_lock);
> - iface = niface = NULL;
> list_for_each_entry_safe(iface, niface, &ses->iface_list,
> iface_head) {
> ret = iface_cmp(iface, &tmp_iface);
prev parent reply other threads:[~2023-05-26 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 12:01 [PATCH] smb: delete an unnecessary statement Dan Carpenter
2023-05-26 15:36 ` Mukesh Ojha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee9c0ab3-028f-cadf-c577-e57a139de5ce@quicinc.com \
--to=quic_mojha@quicinc.com \
--cc=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=pc@manguebit.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox