From mboxrd@z Thu Jan 1 00:00:00 1970 From: "santosh.shilimkar@oracle.com" Date: Wed, 14 Jun 2017 17:18:25 +0000 Subject: Re: [PATCH] RDS: IB: NULL dereference on error in rds_ib_alloc_frmr() Message-Id: List-Id: References: <20170614103924.GK29394@elgon.mountain> In-Reply-To: <20170614103924.GK29394@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Avinash Repaka , linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, kernel-janitors@vger.kernel.org, "netdev@vger.kernel.org" On 6/14/17 3:39 AM, Dan Carpenter wrote: > We accidentally return ERR_PTR(0) if ib_alloc_mr() fails. The caller > is expecting error pointers so it results in a NULL dereference. > > Fixes: 1659185fb4d0 ("RDS: IB: Support Fastreg MR (FRMR) memory registration mode") > Signed-off-by: Dan Carpenter > Thanks Dan for fix. Acked-by: Santosh Shilimkar You haven't copied netdev. Can you please resend the patch with my ack on netdev so that Dave can pick it up.