From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Branden Date: Mon, 01 Feb 2021 22:49:42 +0000 Subject: Re: [PATCH] misc: bcm-vk: unlock on error in bcm_to_h_msg_dequeue() Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Desmond Yan , Dan Carpenter Cc: Arnd Bergmann , Greg Kroah-Hartman , Olof Johansson , bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Great, looks good then. On 2021-02-01 10:32 a.m., Desmond Yan wrote: > Acked-by: Desmond Yan Acked-by: Scott Branden > > On Mon, Feb 1, 2021 at 4:24 AM Dan Carpenter wrote: >> Unlock before returning on this error path. >> >> Fixes: 111d746bb476 ("misc: bcm-vk: add VK messaging support") >> Signed-off-by: Dan Carpenter >> --- >> drivers/misc/bcm-vk/bcm_vk_msg.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/misc/bcm-vk/bcm_vk_msg.c b/drivers/misc/bcm-vk/bcm_vk_msg.c >> index eec90494777d..fc972e43258a 100644 >> --- a/drivers/misc/bcm-vk/bcm_vk_msg.c >> +++ b/drivers/misc/bcm-vk/bcm_vk_msg.c >> @@ -849,7 +849,8 @@ s32 bcm_to_h_msg_dequeue(struct bcm_vk *vk) >> * that is fatal. >> */ >> dev_crit(dev, "Kernel mem allocation failure.\n"); >> - return -ENOMEM; >> + total = -ENOMEM; >> + goto idx_err; >> } >> >> /* flush rd pointer after a message is dequeued */ >> -- >> 2.29.2 >>