From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Max Kellermann <max.kellermann@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 4/6] [media] tda8261: Delete an unnecessary variable initialisation in tda8261_attach()
Date: Tue, 26 Sep 2017 11:32:26 +0000 [thread overview]
Message-ID: <f666b7ca-146e-6574-b066-2b1e034c26f5@users.sourceforge.net> (raw)
In-Reply-To: <15d74bee-7467-4687-24e1-3501c22f6d75@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 26 Sep 2017 12:24:57 +0200
The local variable "state" is reassigned by a statement at the beginning.
Thus omit the explicit initialisation.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/media/dvb-frontends/tda8261.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/tda8261.c b/drivers/media/dvb-frontends/tda8261.c
index e3b4183d00c2..492d8c03a5fa 100644
--- a/drivers/media/dvb-frontends/tda8261.c
+++ b/drivers/media/dvb-frontends/tda8261.c
@@ -183,7 +183,7 @@ struct dvb_frontend *tda8261_attach(struct dvb_frontend *fe,
const struct tda8261_config *config,
struct i2c_adapter *i2c)
{
- struct tda8261_state *state = NULL;
+ struct tda8261_state *state;
state = kzalloc(sizeof(*state), GFP_KERNEL);
if (!state)
--
2.14.1
next prev parent reply other threads:[~2017-09-26 11:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 11:26 [PATCH 0/6] [media] TDA8261: Fine-tuning for five function implementations SF Markus Elfring
2017-09-26 11:27 ` [PATCH 1/6] [media] tda8261: Use common error handling code in tda8261_set_params() SF Markus Elfring
2017-09-26 11:45 ` Christoph Böhmwalder
2017-09-26 16:50 ` SF Markus Elfring
2017-09-26 11:28 ` [PATCH 2/6] [media] tda8261: Improve a size determination in tda8261_attach() SF Markus Elfring
2017-09-26 11:30 ` [PATCH 3/6] [media] tda8261: Return directly after a failed kzalloc() " SF Markus Elfring
2017-09-26 11:32 ` SF Markus Elfring [this message]
2017-09-26 11:33 ` [PATCH 5/6] [media] tda8261: Adjust three function calls together with a variable assignment SF Markus Elfring
2017-09-26 11:34 ` [PATCH 6/6] [media] tda8261: Delete an unnecessary variable initialisation in three functions SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f666b7ca-146e-6574-b066-2b1e034c26f5@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=max.kellermann@gmail.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox