From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 22 Aug 2017 13:15:02 +0000 Subject: Re: [alsa-devel] ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe() Message-Id: List-Id: References: <08ee0d6b-788b-2845-6964-e1e55c2d2292@users.sourceforge.net> <20170822121625.syvr64kwyh5xjexg@mwanda> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Takashi Iwai , alsa-devel@alsa-project.org Cc: kernel-janitors@vger.kernel.org, LKML , Dan Carpenter >> Is it appropriate to treat non-zero values as error codes there generally? > > No, it can't be in general. I got the impression that the functions which are called at the updated places by the function “snd_card_pcsp_probe” indicate a successful execution only by zero so far. > Lots of functions return a positive value, too. Would you like to point any example out from the programming interface? Regards, Markus