From: "Christophe Jaillet" <christophe.jaillet@wanadoo.fr>
To: linux-kernel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org
Subject: Re: [patch] arch/powerpc/platforms/pseries/ras.c - cleanup
Date: Tue, 09 Mar 2010 06:14:50 +0000 [thread overview]
Message-ID: <hn4p0r$gv7$1@dough.gmane.org> (raw)
In-Reply-To: Pine.LNX.4.64.1003082235030.5727@ask.diku.dk
I personaly think that yes, because the smaller, the better.
Could you write one of your semantic match and send the patches ?
CJ
"Julia Lawall" <julia@diku.dk> a écrit dans le message de
news:Pine.LNX.4.64.1003082235030.5727@ask.diku.dk...
> On Mon, 8 Mar 2010, Christophe Jaillet wrote:
>
> > From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
> >
> > Hi, here is a patch against arch/powerpc/platforms/pseries/ras.c.
> >
> > No need to memset (.., 0, ...) a buffer that is complety filled by a
memcpy
> > the line after.
>
> I find 14 occurrences of this in linux-next. Could it be useful for
> something?
>
> julia
>
>
> >
> >
> > Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
> >
> > ---
> >
> > diff --git a/arch/powerpc/platforms/pseries/ras.c
> > b/arch/powerpc/platforms/pseries/ras.c
> > index 2b548af..7a401ed 100644
> > --- a/arch/powerpc/platforms/pseries/ras.c
> > +++ b/arch/powerpc/platforms/pseries/ras.c
> > @@ -276,7 +276,6 @@ static struct rtas_error_log
*fwnmi_get_errinfo(struct
> > pt_regs *regs)
> > (errdata >= rtas.base && errdata < rtas.base + rtas.size - 16)) {
> > savep = __va(errdata);
> > regs->gpr[3] = savep[0]; /* restore original r3 */
> > - memset(mce_data_buf, 0, RTAS_ERROR_LOG_MAX);
> > memcpy(mce_data_buf, (char *)(savep + 1), RTAS_ERROR_LOG_MAX);
> > errhdr = (struct rtas_error_log *)mce_data_buf;
> > } else {
> >
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe
kernel-janitors" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-03-09 6:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 21:06 [patch] arch/powerpc/platforms/pseries/ras.c - cleanup Christophe Jaillet
2010-03-08 21:36 ` Julia Lawall
2010-03-09 6:14 ` Christophe Jaillet [this message]
2010-03-09 17:21 ` Julia Lawall
2010-03-09 10:44 ` Bernd Petrovitsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='hn4p0r$gv7$1@dough.gmane.org' \
--to=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox