From: WANG Cong <xiyou.wangcong@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: linux-acpi@vger.kernel.org
Subject: Re: [PATCH] acpi: debugfs: fix buffer overflows, double free
Date: Fri, 21 Jan 2011 08:06:22 +0000 [thread overview]
Message-ID: <ihbepu$jbj$2@dough.gmane.org> (raw)
In-Reply-To: 1295554086-23873-1-git-send-email-segoon@openwall.com
On Thu, 20 Jan 2011 23:08:06 +0300, Vasiliy Kulikov wrote:
> File position is not controlled, it may lead to overwrites of arbitrary
> kernel memory. Also the code may kfree() the same pointer multiple
> times.
>
> One more flaw is still present: if multiple processes open the file then
> all 3 static variables are shared, leading to various race conditions.
> They should be moved to file->private_data.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
Thanks.
next prev parent reply other threads:[~2011-01-21 8:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 20:08 [PATCH] acpi: debugfs: fix buffer overflows, double free Vasiliy Kulikov
2011-01-21 8:06 ` WANG Cong [this message]
2011-01-21 9:37 ` Eugene Teo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ihbepu$jbj$2@dough.gmane.org' \
--to=xiyou.wangcong@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox