From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Date: Thu, 28 Jul 2011 22:34:07 +0000 Subject: Re: [PATCH] cb710: fix possible pci_dev leak in cb710_pci_configure() Message-Id: List-Id: References: <20110728183319.GC24120@rere.qmqm.pl> In-Reply-To: (=?utf-8?Q?=22Micha=C5=82_Miros=C5=82aw=22's?= message of "Thu, 28 Jul 2011 20:55:27 +0200 (CEST)") MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: =?utf-8?Q?Micha=C5=82_Miros=C5=82aw?= Cc: linux-mmc@vger.kernel.org, kernel-janitors@vger.kernel.org, Julia Lawall Hi Michał, On Thu, Jul 28 2011, Michał Mirosław wrote: > Reported-by: Julia Lawall > Signed-off-by: Michał Mirosław > --- > drivers/misc/cb710/core.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/misc/cb710/core.c b/drivers/misc/cb710/core.c > index efec413..68cd05b 100644 > --- a/drivers/misc/cb710/core.c > +++ b/drivers/misc/cb710/core.c > @@ -33,7 +33,7 @@ EXPORT_SYMBOL_GPL(cb710_pci_update_config_reg); > static int __devinit cb710_pci_configure(struct pci_dev *pdev) > { > unsigned int devfn = PCI_DEVFN(PCI_SLOT(pdev->devfn), 0); > - struct pci_dev *pdev0 = pci_get_slot(pdev->bus, devfn); > + struct pci_dev *pdev0; > u32 val; > > cb710_pci_update_config_reg(pdev, 0x48, > @@ -43,6 +43,7 @@ static int __devinit cb710_pci_configure(struct pci_dev *pdev) > if (val & 0x80000000) > return 0; > > + pdev0 = pci_get_slot(pdev->bus, devfn); > if (!pdev0) > return -ENODEV; Pushed to mmc-next for 3.1, thanks. - Chris. -- Chris Ball One Laptop Per Child