From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikola Pajkovsky Date: Sun, 19 Feb 2012 20:28:02 +0000 Subject: Re: [PATCH] b44: fix section mismatch warnings in b44.c Message-Id: List-Id: References: <20120219201332.GF2855@mwanda> In-Reply-To: <20120219201332.GF2855@mwanda> (Dan Carpenter's message of "Sun, 19 Feb 2012 23:13:32 +0300") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Gary Zambrano , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, Nikola Pajkovsky Dan Carpenter writes: > On Sun, Feb 19, 2012 at 03:45:54PM +0100, Nikola Pajkovsky wrote: >> From: Nikola Pajkovsky >> > > This changelog is not really helpful. > > Why did you remove an __exit anotation instead changing the callers? > Obviously I looked at the code, so I can answer that question, but I > shouldn't have to. It should be explained in the changelog. I will rephrase comment > Sometimes I add in information about when the error message was > introduced. > > It might also be nice to mention what the bad effects of this > problem are. > >> Signed-off-by: Nikola Pajkovsky > ^^^^^^^^^^^^^^^^^^^^^ > You're sending the patch from your redhat address; it's best to sign > it with the redhat address as well. oops, it should be from gmail -- Nikola