From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] s390: char: Free memory on error path.
Date: Mon, 19 Jan 2015 22:06:29 +0000 [thread overview]
Message-ID: <m9jv55$djq$1@ger.gmane.org> (raw)
In-Reply-To: <1421704920-29820-1-git-send-email-christophe.jaillet@wanadoo.fr>
Hi there,
this is my first patch, so feel free to show me anything I did wrong, so
that I can improve next proposals.
Thanks in advance.
CJ
Le 19/01/2015 23:02, Christophe Jaillet a écrit :
> Free allocated page in case of error returned by hmcdrv_ftp_startup.
>
> Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
> ---
> drivers/s390/char/hmcdrv_ftp.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/s390/char/hmcdrv_ftp.c b/drivers/s390/char/hmcdrv_ftp.c
> index 4bd6332..f6e00af 100644
> --- a/drivers/s390/char/hmcdrv_ftp.c
> +++ b/drivers/s390/char/hmcdrv_ftp.c
> @@ -199,8 +199,10 @@ int hmcdrv_ftp_probe(void)
>
> rc = hmcdrv_ftp_startup();
>
> - if (rc)
> + if (rc) {
> + free_page((unsigned long) ftp.buf);
> return rc;
> + }
>
> rc = hmcdrv_ftp_do(&ftp);
> free_page((unsigned long) ftp.buf);
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-01-19 22:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 22:02 [PATCH] s390: char: Free memory on error path Christophe Jaillet
2015-01-19 22:06 ` Christophe JAILLET [this message]
2015-01-20 10:30 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='m9jv55$djq$1@ger.gmane.org' \
--to=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).