From: Corentin Chary <corentin.chary@gmail.com>
To: Dan Carpenter <error27@gmail.com>,
Corentin Chary <corentincj@iksaif.net>,
Matthew Garrett <mjg@redhat.com>, Len Brown <len.brown@intel.com>,
Alan Jenkins <alan-jenkins@tuffmail.co.uk>,
acpi4asus-user@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] asus: don't modify bluetooth/wlan on boot
Date: Tue, 06 Apr 2010 18:46:06 +0000 [thread overview]
Message-ID: <p2x71cd59b01004061146x25f04dfy82e1aba72ddfd3ff@mail.gmail.com> (raw)
In-Reply-To: <20100406104429.GB21229@bicker>
On Tue, Apr 6, 2010 at 12:44 PM, Dan Carpenter <error27@gmail.com> wrote:
> We were storing -1 as an unsigned int and as a result the effect of
> passing -1 was the same as using 1.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index 475ab50..f532336 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -78,15 +78,15 @@ static uint wapf = 1;
> module_param(wapf, uint, 0644);
> MODULE_PARM_DESC(wapf, "WAPF value");
>
> -static uint wlan_status = 1;
> -static uint bluetooth_status = 1;
> +static int wlan_status = 1;
> +static int bluetooth_status = 1;
>
> -module_param(wlan_status, uint, 0644);
> +module_param(wlan_status, int, 0644);
> MODULE_PARM_DESC(wlan_status, "Set the wireless status on boot "
> "(0 = disabled, 1 = enabled, -1 = don't do anything). "
> "default is 1");
>
> -module_param(bluetooth_status, uint, 0644);
> +module_param(bluetooth_status, int, 0644);
> MODULE_PARM_DESC(bluetooth_status, "Set the wireless status on boot "
> "(0 = disabled, 1 = enabled, -1 = don't do anything). "
> "default is 1");
> --
Thanks !
Acked-by: Corentin Chary <corentincj@iksaif.net>
--
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-04-06 18:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 10:44 [patch] asus: don't modify bluetooth/wlan on boot Dan Carpenter
2010-04-06 18:46 ` Corentin Chary [this message]
2010-04-12 17:12 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p2x71cd59b01004061146x25f04dfy82e1aba72ddfd3ff@mail.gmail.com \
--to=corentin.chary@gmail.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=corentincj@iksaif.net \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).