* [patch] asus: don't modify bluetooth/wlan on boot
@ 2010-04-06 10:44 Dan Carpenter
2010-04-06 18:46 ` Corentin Chary
2010-04-12 17:12 ` Matthew Garrett
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2010-04-06 10:44 UTC (permalink / raw)
To: Corentin Chary
Cc: Matthew Garrett, Len Brown, Alan Jenkins, acpi4asus-user,
platform-driver-x86, linux-kernel, kernel-janitors
We were storing -1 as an unsigned int and as a result the effect of
passing -1 was the same as using 1.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
index 475ab50..f532336 100644
--- a/drivers/platform/x86/asus-laptop.c
+++ b/drivers/platform/x86/asus-laptop.c
@@ -78,15 +78,15 @@ static uint wapf = 1;
module_param(wapf, uint, 0644);
MODULE_PARM_DESC(wapf, "WAPF value");
-static uint wlan_status = 1;
-static uint bluetooth_status = 1;
+static int wlan_status = 1;
+static int bluetooth_status = 1;
-module_param(wlan_status, uint, 0644);
+module_param(wlan_status, int, 0644);
MODULE_PARM_DESC(wlan_status, "Set the wireless status on boot "
"(0 = disabled, 1 = enabled, -1 = don't do anything). "
"default is 1");
-module_param(bluetooth_status, uint, 0644);
+module_param(bluetooth_status, int, 0644);
MODULE_PARM_DESC(bluetooth_status, "Set the wireless status on boot "
"(0 = disabled, 1 = enabled, -1 = don't do anything). "
"default is 1");
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] asus: don't modify bluetooth/wlan on boot
2010-04-06 10:44 [patch] asus: don't modify bluetooth/wlan on boot Dan Carpenter
@ 2010-04-06 18:46 ` Corentin Chary
2010-04-12 17:12 ` Matthew Garrett
1 sibling, 0 replies; 3+ messages in thread
From: Corentin Chary @ 2010-04-06 18:46 UTC (permalink / raw)
To: Dan Carpenter, Corentin Chary, Matthew Garrett, Len Brown,
Alan Jenkins, acpi4asus-user, platform-driver-x86, linux-kernel,
kernel-janitors
On Tue, Apr 6, 2010 at 12:44 PM, Dan Carpenter <error27@gmail.com> wrote:
> We were storing -1 as an unsigned int and as a result the effect of
> passing -1 was the same as using 1.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index 475ab50..f532336 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -78,15 +78,15 @@ static uint wapf = 1;
> module_param(wapf, uint, 0644);
> MODULE_PARM_DESC(wapf, "WAPF value");
>
> -static uint wlan_status = 1;
> -static uint bluetooth_status = 1;
> +static int wlan_status = 1;
> +static int bluetooth_status = 1;
>
> -module_param(wlan_status, uint, 0644);
> +module_param(wlan_status, int, 0644);
> MODULE_PARM_DESC(wlan_status, "Set the wireless status on boot "
> "(0 = disabled, 1 = enabled, -1 = don't do anything). "
> "default is 1");
>
> -module_param(bluetooth_status, uint, 0644);
> +module_param(bluetooth_status, int, 0644);
> MODULE_PARM_DESC(bluetooth_status, "Set the wireless status on boot "
> "(0 = disabled, 1 = enabled, -1 = don't do anything). "
> "default is 1");
> --
Thanks !
Acked-by: Corentin Chary <corentincj@iksaif.net>
--
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] asus: don't modify bluetooth/wlan on boot
2010-04-06 10:44 [patch] asus: don't modify bluetooth/wlan on boot Dan Carpenter
2010-04-06 18:46 ` Corentin Chary
@ 2010-04-12 17:12 ` Matthew Garrett
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Garrett @ 2010-04-12 17:12 UTC (permalink / raw)
To: Dan Carpenter, Corentin Chary, Len Brown, Alan Jenkins,
acpi4asus-user, platform-driver-x86, linux-kernel,
kernel-janitors
Thanks, applied.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-12 17:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-06 10:44 [patch] asus: don't modify bluetooth/wlan on boot Dan Carpenter
2010-04-06 18:46 ` Corentin Chary
2010-04-12 17:12 ` Matthew Garrett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).