From: Takashi Iwai <tiwai@suse.de>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: alsa-devel@alsa-project.org, Arnd Bergmann <arnd@arndb.de>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Ralf Baechle <ralf@linux-mips.org>,
Manuel Lauss <manuel.lauss@gmail.com>
Subject: Re: [PATCH] oss: au1550_ac97: simplify au1550_delay()
Date: Mon, 26 Jul 2010 08:35:20 +0000 [thread overview]
Message-ID: <s5h1vaqy71z.wl%tiwai@suse.de> (raw)
In-Reply-To: <1280132913-8306-1-git-send-email-segooon@gmail.com>
At Mon, 26 Jul 2010 12:28:32 +0400,
Kulikov Vasiliy wrote:
>
> au1550_delay() uses loop with schedule_timeout() to unconditionally wait
> for msec. Use schedule_timeout_uninteruptible() instead.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Thanks, applied both patches.
Takashi
> ---
> sound/oss/au1550_ac97.c | 11 +----------
> 1 files changed, 1 insertions(+), 10 deletions(-)
>
> diff --git a/sound/oss/au1550_ac97.c b/sound/oss/au1550_ac97.c
> index 0fd256c..c4a4cdc 100644
> --- a/sound/oss/au1550_ac97.c
> +++ b/sound/oss/au1550_ac97.c
> @@ -163,19 +163,10 @@ ld2(unsigned int x)
> static void
> au1550_delay(int msec)
> {
> - unsigned long tmo;
> - signed long tmo2;
> -
> if (in_interrupt())
> return;
>
> - tmo = jiffies + (msec * HZ) / 1000;
> - for (;;) {
> - tmo2 = tmo - jiffies;
> - if (tmo2 <= 0)
> - break;
> - schedule_timeout(tmo2);
> - }
> + schedule_timeout_uninterruptible(msecs_to_jiffies(msec));
> }
>
> static u16
> --
> 1.7.0.4
>
prev parent reply other threads:[~2010-07-26 8:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 8:28 [PATCH] oss: au1550_ac97: simplify au1550_delay() Kulikov Vasiliy
2010-07-26 8:35 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h1vaqy71z.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manuel.lauss@gmail.com \
--cc=ralf@linux-mips.org \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox