From: Takashi Iwai <tiwai@suse.de>
To: Lionel Debroux <lionel_debroux@yahoo.fr>
Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, Emese Revfy <re.emese@gmail.com>,
Kees Cook <kees.cook@canonical.com>
Subject: Re: sound: constify snd_ac97_bus_ops
Date: Sun, 24 Jul 2011 11:59:26 +0000 [thread overview]
Message-ID: <s5h4o2b51pd.wl%tiwai@suse.de> (raw)
In-Reply-To: <208430.5747.bm@smtp121.mail.ukl.yahoo.com>
At Sun, 24 Jul 2011 11:40:48 +0200,
Lionel Debroux wrote:
>
> The fields of this struct type don't seem to be used as rvalues, besides
> the initialization of struct instances. Let's make const the struct
> instances.
>
> Maybe the Documentation/DocBook/writing-an-alsa-driver.tmpl, and
> checkpatch.pl should be updated to reflect this change ?
Yes, please either update or give an additional patch for document
fixes.
I'll apply these series not for 3.1 since this changes API. Will be
applied the branches for 3.2.
thanks,
Takashi
prev parent reply other threads:[~2011-07-24 11:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-24 9:40 sound: constify snd_ac97_bus_ops Lionel Debroux
2011-07-24 11:59 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4o2b51pd.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=kees.cook@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lionel_debroux@yahoo.fr \
--cc=re.emese@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox