public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	Vinod Koul <vinod.koul@intel.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ASoC: compress: indent an if statement
Date: Wed, 14 May 2014 15:19:18 +0000	[thread overview]
Message-ID: <s5h61l8gzgp.wl%tiwai@suse.de> (raw)
In-Reply-To: <s5hbnv0h0wk.wl%tiwai@suse.de>

At Wed, 14 May 2014 16:48:11 +0200,
Takashi Iwai wrote:
> 
> At Wed, 14 May 2014 17:23:08 +0300,
> Dan Carpenter wrote:
> > 
> > The return statement was not indented correctly.  I lined up the
> > condition a bit as well.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Applied this one, too.  Thanks.

Oops, I took it mistakenly.  Scratched from my branch now.
Sorry for confusion.


Takashi

> 
> 
> Takashi
> 
> > 
> > diff --git a/sound/soc/soc-compress.c b/sound/soc/soc-compress.c
> > index 91083e6..e4c7ad5 100644
> > --- a/sound/soc/soc-compress.c
> > +++ b/sound/soc/soc-compress.c
> > @@ -317,8 +317,9 @@ static int soc_compr_trigger_fe(struct snd_compr_stream *cstream, int cmd)
> >  		cmd = SND_COMPR_TRIGGER_DRAIN) {
> >  
> >  		if (platform->driver->compr_ops &&
> > -			platform->driver->compr_ops->trigger)
> > -		return platform->driver->compr_ops->trigger(cstream, cmd);
> > +		    platform->driver->compr_ops->trigger)
> > +			return platform->driver->compr_ops->trigger(cstream,
> > +								    cmd);
> >  	}
> >  
> >  	if (cstream->direction = SND_COMPRESS_PLAYBACK)
> > 

  reply	other threads:[~2014-05-14 15:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14 14:23 [patch] ASoC: compress: indent an if statement Dan Carpenter
2014-05-14 14:48 ` Takashi Iwai
2014-05-14 15:19   ` Takashi Iwai [this message]
2014-05-14 15:15 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h61l8gzgp.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=perex@perex.cz \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox