Re: [PATCH 2/3] ALSA: mpu401: Use common error handling code in snd_mpu401_uart_new()

Joe Perches
2017-08-13T01:08:18Z

On Sat, 2017-08-12 at 21:12 +0200, SF Markus Elfring wrote:
> Add a jump target so that a bit of exception handling can be better
> reused at the end of this function.
[]
> diff --git a/sound/drivers/mpu401/mpu401_uart.c b/sound/drivers/mpu401/mpu401_uart.c
[]
> @@ -612,6 +612,9 @@ int snd_mpu401_uart_new(struct snd_card *card, int device,
> if (rrawmidi)
> *rrawmidi = rmidi;
> return 0;
> +free_device:
> + snd_device_free(card, rmidi);
> + return err;
> }
>
> EXPORT_SYMBOL(snd_mpu401_uart_new);

It may be more common and better to leave a blank line
between a single line return and a label.

It separates logical points in the function a bit more.