From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
walter harms <wharms@bfs.de>
Subject: Re: [alsa-devel] [patch v2] [ALSA] hwdep: silence integer overflow warning
Date: Mon, 31 Oct 2011 08:55:46 +0000 [thread overview]
Message-ID: <s5h7h3la6b1.wl%tiwai@suse.de> (raw)
In-Reply-To: <20111028064601.GB14707@longonot.mountain>
At Fri, 28 Oct 2011 09:46:01 +0300,
Dan Carpenter wrote:
>
> Smatch complains that if device is INT_MAX then device + 1 can
> overflow. It just means we would have an annoying loop while we
> check all the devices from -2147483648 to SNDRV_MINOR_HWDEPS.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied now. Thanks!
Takashi
> ---
> v2: reshuffled it a bit per Walter Harms's suggestion.
>
> diff --git a/sound/core/hwdep.c b/sound/core/hwdep.c
> index c7ceb28..75ea16f 100644
> --- a/sound/core/hwdep.c
> +++ b/sound/core/hwdep.c
> @@ -273,7 +273,14 @@ static int snd_hwdep_control_ioctl(struct snd_card *card,
> if (get_user(device, (int __user *)arg))
> return -EFAULT;
> mutex_lock(®ister_mutex);
> - device = device < 0 ? 0 : device + 1;
> +
> + if (device < 0)
> + device = 0;
> + else if (device < SNDRV_MINOR_HWDEPS)
> + device++;
> + else
> + device = SNDRV_MINOR_HWDEPS;
> +
> while (device < SNDRV_MINOR_HWDEPS) {
> if (snd_hwdep_search(card, device))
> break;
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
prev parent reply other threads:[~2011-10-31 8:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 6:09 [patch] [ALSA] hwdep: silence integer overflow warning Dan Carpenter
2011-10-20 7:39 ` walter harms
2011-10-28 6:45 ` Dan Carpenter
2011-10-28 7:33 ` walter harms
2011-10-28 8:55 ` Dan Carpenter
2011-10-28 6:46 ` [patch v2] " Dan Carpenter
2011-10-31 8:55 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h7h3la6b1.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox