From: Takashi Iwai <tiwai@suse.de>
To: Colin King <colin.king@canonical.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] ALSA: opti9xx: fix missing { } around an if block
Date: Tue, 20 Jul 2021 17:40:22 +0200 [thread overview]
Message-ID: <s5ha6mhouxl.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210720153741.73230-1-colin.king@canonical.com>
On Tue, 20 Jul 2021 17:37:41 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently the { } braces are missing around an if block causing subsequent
> code after the return to become unreachable. Fix this by adding the
> missing { }.
>
> Addresses-Coverity: ("Structurally dead code")
> Fixes: 2973ee4a5b54 ("ALSA: opti9xx: Allocate resources with device-managed APIs")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, applied.
Takashi
prev parent reply other threads:[~2021-07-20 15:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 15:37 [PATCH][next] ALSA: opti9xx: fix missing { } around an if block Colin King
2021-07-20 15:40 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5ha6mhouxl.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox