From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Julia Lawall <Julia.Lawall@lip6.fr>
Subject: Re: [alsa-devel] [PATCH] ALSA: via82xx: Use common error handling code in snd_via82xx_create()
Date: Tue, 22 Aug 2017 20:19:39 +0000 [thread overview]
Message-ID: <s5ha82rs6ck.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170822201400.lw3bcjlvx4lzlq5d@mwanda>
On Tue, 22 Aug 2017 22:16:12 +0200,
Dan Carpenter wrote:
>
> On Tue, Aug 22, 2017 at 10:05:37PM +0200, SF Markus Elfring wrote:
> > >> @@ -1121,30 +1121,27 @@ static int snd_via82xx_create(struct snd_card *card,
> > >>
> > >> if ((err = pci_request_regions(pci, card->driver)) < 0) {
> > >> kfree(chip);
> > >> - pci_disable_device(pci);
> > >> - return err;
> > >> + goto disable_device;
>
> Ah, you're right. It's not leaking. I thought you deleted the
> kfree(chip);...
Well, this also suggests something wrong by the patch...
If you can't achieve it cleanly, better not to touch it in a
half-baked way.
Takashi
prev parent reply other threads:[~2017-08-22 20:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 17:43 [PATCH] ALSA: via82xx: Use common error handling code in snd_via82xx_create() SF Markus Elfring
2017-08-22 17:57 ` Takashi Iwai
2017-11-19 6:37 ` SF Markus Elfring
2017-08-22 19:07 ` Dan Carpenter
2017-08-22 20:05 ` SF Markus Elfring
2017-08-22 20:16 ` Dan Carpenter
2017-08-22 20:19 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5ha82rs6ck.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=Julia.Lawall@lip6.fr \
--cc=alsa-devel@alsa-project.org \
--cc=dan.carpenter@oracle.com \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox