From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC23EC48BE6 for ; Wed, 16 Jun 2021 06:53:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99FCB61246 for ; Wed, 16 Jun 2021 06:53:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231696AbhFPGz7 (ORCPT ); Wed, 16 Jun 2021 02:55:59 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:55790 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231309AbhFPGzx (ORCPT ); Wed, 16 Jun 2021 02:55:53 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 679E41FD60; Wed, 16 Jun 2021 06:53:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1623826427; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rw34yZqXHDppUBaot5Jq8vMZnluEjhZukXnTfLjMgc4=; b=gQcNSllAIpd7mnAIOWHMrPjP/CkmhCYmMHOj0OhMX6eu10mQv+RenRhq/7BCUotaOGwjfJ sSK7yzq5MvU+sZZn6Y96YCZEOSnhX3eM1B7WUzFH6X/6JDwB13mgWZFtkpCUr4LEiUjmlk r2SgGZi5j/QVxFCvyiMoSO1xxMzhvZk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1623826427; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rw34yZqXHDppUBaot5Jq8vMZnluEjhZukXnTfLjMgc4=; b=G4fVMevDww0GZrlpq6Vjlgv6hA8KNDRjm2sehMPIj1cBa87U7G9aJGu2yhh5EQUHxvvt/p YEaBhex7NcVP3DAQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id E0969A3B8A; Wed, 16 Jun 2021 06:53:46 +0000 (UTC) Date: Wed, 16 Jun 2021 08:53:46 +0200 Message-ID: From: Takashi Iwai To: Colin King Cc: Clemens Ladisch , Takashi Sakamoto , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] ALSA: bebob: Fix bit flag quirk constants In-Reply-To: <20210615142048.59900-1-colin.king@canonical.com> References: <20210615142048.59900-1-colin.king@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Tue, 15 Jun 2021 16:20:48 +0200, Colin King wrote: > > From: Colin Ian King > > The quirking bit-flags are currently set as contiguous integer enum values > and so currently SND_BEBOB_QUIRK_INITIAL_DISCONTINUOUS_DBC is zero and so > he quirking never getting set or tested correctly for this quirk. Fix this > by setting the quirking constants as shifted bit values. > > Addresses-Coverity: ("Bitwise-and with zero") > Fixes: 93cd12d6e88a ("ALSA: bebob: code refactoring for model-dependent quirks") > Signed-off-by: Colin Ian King Thanks, applied. Takashi